News for hackers. Stuff that matters.
Re:Introducing review requests by piotrkaminski on Wednesday December 07, 2016 @07:25PM (#13127466)
Heh, I never cease to wonder at the variety of -- often contradictory -- code review workflows. For me and many others automatically disappearing comments are a misfeature, since we _want_ to verify that a comment was correctly addressed. To each their own... :)
Re:Introducing review requests by gkop on Wednesday December 07, 2016 @07:43PM (#13127550)
At the launch of GitHub reviews, it's not just that the outdated comments weren't hidden, but at that time, there were no tools in place of that to collapse threads, mark sections of diff as approved, or otherwise resolve comments with follow-on pushes. That's why I asked their support if I was using it correctly, I was super confused. I'm definitely interested in a better GitHub workflow.