Re:It Takes 6 Days to Change 1 Line of Code (2015)
by user5994461 on Tuesday December 06, 2016 @10:43PM
(#13120308)
I don't get it. The two groups are not mutually exclusive.
It can be annoying to go past code reviews and yet there are fire everywhere all the time.
Re:It Takes 6 Days to Change 1 Line of Code (2015)
by lisivka on Tuesday December 06, 2016 @11:37PM
(#13120509)
It's very unlikely. Peer-reviews are spreading information across team, so at least two team members are understanding every area of the code, so project manager can always add more members to urgent or problematic task quickly.
Re:It Takes 6 Days to Change 1 Line of Code (2015)
by mdpopescu on Thursday December 08, 2016 @02:32PM
(#13133359)
I have worked in one place where you couldn't get the code to pass without tests AND a code review.
One of the methods I found had a cyclomatic complexity of 200+ and a single test, verifying that the result was not null.
I was told "no, you can't fix that, the NY office wrote it and they'll get angry with us if we change their code and refuse to help".
Things are worse than you think :)
Re:It Takes 6 Days to Change 1 Line of Code (2015)
by user5994461 on Wednesday December 07, 2016 @05:31AM
(#13121641)
Depends on how much people care. The code review could be half assed and not detect issues.
Of the two, I've had to unexpectedly work nights, weekends or even vacations at only one kind.
Guess which one I decided I'd rather work at.