Re:Gongular – A new web framework for Go
by zalmoxes on Monday December 05, 2016 @03:09PM
(#13108952)
I'm sorry, but does anyone even glance at the source of these frameworks before they're upvoted?
[ Parent
| on HN ]
Re:Gongular – A new web framework for Go
by alistproducer2 on Monday December 05, 2016 @03:20PM
(#13109054)
I've said the exact thing on multiple occasions. For example, https://news.ycombinator.com/item?id=12892550. this dude created something that opened a port and listened for commands that would control your OS. He hadn't spent 5 minutes making even some basic form of authentication and came straight to HN for the high 5's. People tried to flame me for pointing out that it seemed irresponsible to be promoting software in such a state.
Re:Gongular – A new web framework for Go
by BoorishBears on Monday December 05, 2016 @07:49PM
(#13111328)
The current top comments all say what you said without the unwarranted snark.
I've withdrawn my upvote after I saw this in the code:
type Injector struct {
values map[reflect.Type]interface{}
customProviders map[reflect.Type]CustomProvideFunction
}
Re:Gongular – A new web framework for Go
by bigblind on Monday December 05, 2016 @03:46PM
(#13109368)
Comments like this could be extremely helpful to the author if you explain more clearly what you mean. Is it because they're using reflection so much? Or is it because a CustomProvideFunction could also be stored as interface{} or something completely different? I'm fairly new to Go as well, so I'm curious.
Re:Gongular – A new web framework for Go
by komali2 on Monday December 05, 2016 @03:19PM
(#13109049)
I don't understand, what's wrong with that? I've never used Go so I'm asking out of ignorance.
It is not type safe and relies on runtime reflection based checks to make it work correctly, it can crash easily. However, I believe I made all the checks correctly and it should work as intended, but of course it is only 600 LOC, there can arise some issues.
Re:Gongular – A new web framework for Go
by adregan on Monday December 05, 2016 @03:44PM
(#13109335)
Perhaps due to the fact that upvoting privately saves the story and doesn't forward you to another page as favoriting does (which isn't private), people are upvoting with the intention of browsing it later.
I mention it because it is something I do frequently, and I do this because the favoriting feature isn't quite right (I want to privately save stories for later and I don't want to be redirected).
Re:Gongular – A new web framework for Go
by ben_jones on Monday December 05, 2016 @03:21PM
(#13109067)
I'll always advocate learning projects like this, but you're absolutely right that if anyone pulls it for production they deserve what they get.
My personal litmus test for OSS is to read the test suite.
Unfortunately, to achieve the functionality I described, I must have used reflection like that, which is not really nice, but I really prefer it to context based methods type assuming and casting which is essentially the same. I know people do not like reflection that is used like this, but the performance is not a concern, and I really got tired of transforming user input and checking for errors in each handler.