Re:What I learned from spending 3 months applying to jobs af...
by sushid on Monday November 21, 2016 @04:19PM
(#13009311)
Looks like your refactor could use a test or two :p
[ Parent
| on HN ]
Re:What I learned from spending 3 months applying to jobs af...
by alexc05 on Monday November 21, 2016 @04:28PM
(#13009362)
OMG - you're 100% right and I've already passed the "you're still allowed to edit or delete this post" time limit imposed by HN.
This is going to be a black mark on my OCD coder's soul for the rest of time. A code typo immortalised next to my name.
/sigh.
There's a lesson for me... Never. Ever. Attempt to be clever on hackernews.
Thanks for pointing it out.
... I wonder if HN mods would be willing to spare me this suffering. Undoubtedly a waste of their time.
Re:What I learned from spending 3 months applying to jobs af...
by UweSchmidt on Monday November 21, 2016 @06:23PM
(#13010249)
Judge and you will be judged :)
Seriously, the original code is not too bad and probably what most people would write if the inputs and functionality of that function are only complex enough. "Hm, what else goes into isPrepared? Do I have to consider anything else before returning true or false?"