News for hackers. Stuff that matters.

A comment on Introducing code reviews to a team – Part 1. Parent comment

Re:Introducing code reviews to a team – Part 1 by AnimalMuppet on Friday November 18, 2016 @12:10PM (#12988221)
In our environment, you're supposed to have compiled it and run the tests before you even bother asking for a code review.
[ Parent | on HN ]
Re:Introducing code reviews to a team – Part 1 by dllthomas on Friday November 18, 2016 @12:14PM (#12988256)
That's typically the case for us, although there's an occasional "before I finish it, what do you think of this direction?". Not a problem when rare and called out special.
[ Parent | on HN ]