> So, what's the current recommendation on accepting public ICMP these days?

The recommendation is to accept ALL ICMP traffic, from everywhere, to everywhere, whatever it is.

I've wasted too much time debugging tricky network issues because a dude thought that blocking ICMP was a great idea.