- This looks good
- this looks bad
- this looks extremely bad
- this is dangerous, I imagine you can exploit this
- You can easily exploit this code with attached example
A free scale if you need to convey degree of good/badness for attached code. CC0 license.
This is a bit snarky, but I do think that a bit of effort can be made to describe code as being bad without declaring that the author's mother should have aborted them.
Re:Crocker's rules
by icebraining on Monday November 07, 2016 @02:45AM
(#12889524)
Well, taking the "shut the fuck up" incident, the scale was used at the maximum level (an example of the commit breaking a program was provided, with a patch fixing it) and the maintainer insisted it wasn't really a bug because the app was holding it wrong. Therefore, your scale needs an extra level.
That's important information.
From Torvalds:
The fact is, people need to know what my position on things are. And I can't just say "please don't do that", because people won't listen. I say "On the internet, nobody can hear you being subtle," and I mean it.
And I definitely am not willing to string people along, either. I've had that happen too—not telling people clearly enough that I don't like their approach, they go on to re-architect something, and get really upset when I am then not willing to take their work.