Having practiced medicine for a long time and working with thousands of people with behavioral/emotional disorders of many kinds, I can assure you that there is no necessary correlation between cognitive capability and "success" measured by any number of criteria.
When life difficulty seems out of phase with ability, it's wise to seek consultation or evaluation to find out if there is a correctable problem. As I've observed countless times, even geniuses (seriously) can have learning disorders, depression, anxiety and attentional disorders. These can be surprisingly disabling, and in many cases appropriate treatment can make a world of difference. I've seen that occur in many instances too.
BTW it is known that conditions of the kind I mention have moderate or strong heritability, so your description of a family characteristic of less success than would be expected may point to traits that "run in the family". All the more reason to check it out. I strongly believe it's never too late to make improvements in one's life, and we always have the obligation to take good care of ourselves.
If you look at statistics you will see things like 'Average IQ of University Professor is 125 were as average IQ of factory worker is 85'.
That sounds cool and all until you realize that the number of people that work at a university as professors is in the dozens were as the number of people that work at a factory is in the hundreds... and that average IQ spread of factory workers is 70 to 140 and the spread of professors is 110 to 140. These things operate on bell curves.
Which means that there are a lot more high IQ people working at the factory then there are working at the university.
Which means if you want to figure out what people are more likely to succeed in life then you should just ignore IQ and concentrate on what they have already managed to achieve.
My parents can barely manage their lives, and I'm the only child (of 4) who was able to finish college. So, I always find the fascination with IQ to be odd.
At 3rd grade, my siblings and I were separated from the rest of the kids and given the gifted label. (Someone once explained that 'gifted' was a cold war program to beat the soviets - idk). We were then given special treatment: small classes, lots of logic puzzles, access to technology and science, lots of field trips etc.
By the end of high school, approximately 25% of my class had already dropped out. But, for some odd reason (probably because obedience - i.e. 'conscientiousness') I succeeded.
Over all of those years, I came to realize that there were kids with high IQ who were smart but even more who were very stupid. Even of the smart ones, many of them seemed to completely lack creativity, intuition, or lateral thinking. And, many were also stricken with major behavioral and learning disabilities.
I realize that there are correlations with IQ to 'success'. But, the IQ club, for me, was really a circle jerk. And, I don't believe that they're somehow more re 'fit'. So, this analysis seems spot on.
Edit: oops, if I had actually read the link, instead of just the headline, I would have seen that it's not 'spot on'. Sorry :-)