I suppose because I am comparing post-Oslo Palestinian terrorism to early 20th Century Zionist terrorism. Fair point. I'm not sure I agree that Palestine kinda sorta having statehood counts as much a victory, compared to the concrete losses suffered by Palestinians. It's not like Palestinians actually have much control over the territory their state claims.
Palestinian terroristm increased drastically with every concession Israel made.
Suicide bombings after Oslo (they weren't really any before), and the 2nd intifada after Camp David when they were offered 98% of thier claimed territory with land swaps and East Jerusalem, and after Israel pulled out of Gaza it got 10,000's of rockets.
Terrorism can work when it's a means to an end, not the goal itself.
Why do you say it hasn't worked out for the Palestinians? If it wasn't for the PLO there would be no Palestinian state [1] and the PLO became prominent through terrorist acts [2].
There's a good number of organizations in history that have started with terrorist acts (i.e. atacks against civilians) and ended up in control of a relatively stable territorial state. They include the FLN in Algeria [3], Hezbollah in South Lebanon [4] and the armed wing of the ANC in South Africa [5]. Sure, most if not all have now renounced their terrorist beginnings - so maybe terrorism is not a strategy for the long run. But it's repeatedly provided the initial stepping stone to forming a government.
[1] https://en.wikipedia.org/wiki/Oslo_Accords
[2] https://en.wikipedia.org/wiki/Palestine_Liberation_Organizat...
[3] https://en.wikipedia.org/wiki/Algerian_War#Battle_of_Algiers
[4] https://en.wikipedia.org/wiki/History_of_Hezbollah#Suicide_a...
[5] https://en.wikipedia.org/wiki/Umkhonto_we_Sizwe#Bombings