News for hackers. Stuff that matters.

A comment on Applying the Linus Torvalds “Good Taste” Coding Requirement. Parent comment

Re:Applying the Linus Torvalds “Good Taste” Coding Requirement by tempestn on Wednesday October 26, 2016 @04:01AM (#12794722)
I agree with you that moving the conditional to the beginning as an early exit keeps things simple, and while I don't see anything unusual about a 'while' loop and feel they have their place, this 'for' definitely works well.

I would make one small tweak, replacing this line

    prev->next = prev->next->next;
with

    prev->next = entry->next;
Just makes it a bit more straightforward to understand (as well as infinitesimally more efficient).
[ Parent | on HN ]
Re:Applying the Linus Torvalds “Good Taste” Coding Requirement by akkartik on Wednesday October 26, 2016 @01:01PM (#12798224)
Yes, I'd be ok with a `while` that checked for the end of the list: https://news.ycombinator.com/item?id=12798192

I really try not to be a nazi about this sort of thing. Very few things matter enough to get into a HN conversation about "taste".

[ Parent | on HN ]
Re:Applying the Linus Torvalds “Good Taste” Coding Requirement by tempestn on Wednesday October 26, 2016 @05:52PM (#12800990)
Totally, it's not about the one right way to do something. I do think there's some value in putting thought into how to write.. maybe "clean" code would be a less charged word than tasteful.
[ Parent | on HN ]