They should have been buying based off the assets in the investment not based off of the counterparty.
Because the party who was short on the product was the same party who created the product, and Goldman did not inform investors of this fact. It's not a matter of just buying and selling. The RMBS's underlying the CDO were packaged by a party who had significant interest in seeing the package blow up.
An Oversimplified Analogy:
Imagine that I come to you and say, "I have a document that represents 100 mortgages and I'd like to broker a sale. If you buy this document, as long as less than ten of these mortgages go into default, you make money. If more than ten of them go into default, your counterparty in the sale (not me) will make money."
"Okay," you say, "that sounds interesting. So where did all these mortgages come from?"
"Oh, we got an independent company to pick a bunch of mortgages that they consider fairly safe and that they believe are a good representation of the overall U.S. mortgage market."
"Great!" you say, and you buy a billion dollars worth. More than ten mortgages end up defaulting and you lose a shit ton of money. Imagine your dismay when you learn that the mortgages were not packaged by some third party as I claimed, but hand-picked by the very counterparty you were betting against. OBVIOUSLY if they were going to benefit from more than ten mortgages defaulting, they would have filled the entire document full of mortgages they expected to fail! This is fraud in its most basic form!
But if you're betting against Hank, who manages the Griffons, that's something you want to be made aware of. Even if he can't directly influence the game, knowing that your opponent picked the players for the team he's betting against, he's got a lot of information that you can't easily come by, and it'd be a bad move to bet against him. It's a bit of a bait and switch to say that you're betting against another neutral party when you're in fact betting against someone involved in the game.
The fact that the people structuring the deal were short on the deal is evidence suggesting a far, far more involved analysis before getting involved. That's a red flag that should cause significantly more due diligence. The entire purpose of the SEC is to make sure that such material information is not lied about.
You have to separate issues here. Paulson & Co. were counterparties on a credit default swap with Goldman Sachs. That is fine. Goldman Sachs failed to disclose information to investors about Paulson & Co's role, and lied about their position. That is what the SEC is upset about.
You are right that the credit default swap was a zero sum bet between equally informed counterparties. It so happens that one side analyzed the deal better. (Actually that is questionable. The bankers on the Goldman Sachs side knew that they would get large personal bonuses no matter what happened to Goldman Sachs. So they may have analyzed it correctly and done what was in their best interest. But let's not get into perverse incentives.)
The issue that the SEC has with the scenario is that not only did Goldman Sachs fail to disclose Paulson & Co's involvement (instead saying that ACA had selected all of the bonds), they told investors that Paulson & Co had $200 million in equity in the deal, without disclosing the credit default swap position that meant Paulson & Co were actually significantly net short. This was a lie, and that is why Goldman Sachs is in trouble here.
Edit I had the parties wrong. Fixed.