News for hackers. Stuff that matters.
Re:Be Kind by AdmiralAsshat on Friday October 14, 2016 @09:15AM (#12707822)
Isn't there supposed to be a code review before devs are allowed to deploy something to production?

Yeah, Brian screwed up. But the company has at least some fault for letting him get that far unchecked.

Re:Be Kind by etrain on Friday October 14, 2016 @09:22AM (#12707861)
This varies highly depending on the organization. I've worked at places that do it both ways. Particularly in small places when resources are tight, teams are distributed, or there is a non-code safety measure in place (e.g. Business decisions are made ex-post of the code running dependent on the quality of its output), code reviews pre-deployment may not be necessary and can even be harmful (due to wasted resources).
Re:Be Kind by bgilham on Friday October 14, 2016 @09:50AM (#12708034)
This was far enough in the past that code reviews and "Don't deploy on Friday" weren't necessarily taken as standard practice at a lot of companies yet. But yes, we all learned :-)
Re:Be Kind by chris_wot on Friday October 14, 2016 @09:19AM (#12707848)
Sure, and I don't see them blaming Brian in any way.