News for hackers. Stuff that matters.
Re:Golang landmines by smarterclayton on Sunday September 18, 2016 @01:36AM (#12524068)
I don't consider the linters enough to defend against shadowing - on Kubernetes we find one or two err shadowing bugs a month (https://github.com/kubernetes/kubernetes/search?p=1&q=shadow... is just the ones for a trivial search) that can sometimes be quite serious (I fixed one last week that leaked scheduler workers - https://github.com/kubernetes/kubernetes/pull/32643). Being extremely strict on shadowing has helped some, but it also leads to code which looks non-idiomatic and is slightly worse to read and review.

Taking address of a loop variable has also come up several times, although linters have many fewer false positives there.

There are no comments on this comment yet.