My point is that being based on XMPP is still a good thing, regardless of whether they federate or not.
Can you connect with third party clients? Can they federate? Are they contributing to the protocol? No.
So what's good about it?
E.g. it benefits you that Google uses TCP internally, even if you can't get on their network? Why? Because they've submitted patches to Linux to make it work better.
But they didn't modify TCP to prevent interoperability did they?
Maybe someone outside Google gains nothing, but presumably their engineers will spend less time reinvesting the wheel, which is a net gain for humanity in less time wasted.
Well, bad news then: They never federated and they modified their implementation of XMPP to the point of third party clients not being able to connect.
I'm missing something here; why is this a bad thing?