News for hackers. Stuff that matters.
Re:Exploiting Misuse of Python's “Pickle” by GauntletWizard on Sunday June 05, 2016 @08:31PM (#11843923)
Mu. Unask the question. Serializing a function is itself the security hole, because who knows what that function does? A function is just as possibly malicious code as whatever else you think you're using it for.
Re:Exploiting Misuse of Python's “Pickle” by xapata on Sunday June 05, 2016 @11:19PM (#11844447)
Being connected to the internet is a security hole. I'll balance security with practicality.
Re:Exploiting Misuse of Python's “Pickle” by ludamad on Monday June 06, 2016 @02:21AM (#11844998)
The GP's point is if you're doing code deserialization, the definition of security is different. The data format having RCE bugs won't be as much of a concern, while trusting the data source will be much more of a concern.
Re:Exploiting Misuse of Python's “Pickle” by xapata on Monday June 06, 2016 @01:22PM (#11848446)
We redefine security for every project. Some projects can (de)serialize code and be secure. Others can't.
Re:Exploiting Misuse of Python's “Pickle” by IanCal on Monday June 06, 2016 @02:24AM (#11845011)
If someone is able to modify my local files and wants to change the code I'm running, what is it about pickle that makes me vulnerable? They'd already be in a position where they could change my actual code.
Re:Exploiting Misuse of Python's “Pickle” by GauntletWizard on Monday June 06, 2016 @02:53AM (#11845085)
Why do you think the attacker has the ability to change your local files? That's not the attack surface. The attack surface is when it's used in a wire format for network communication. The attack surface is the attacker convincing you to download a file in a format that you don't realize is executable and every file format that includes pickled objects is vulnerable. The attack surface is that you've confused data and code; There's a reason why OpenBSD now enforces W^X, and that is that there's very different domains of trust. I'd trust my neighbor down the street to send me a spreadsheet, I'd not trust him to send me a program (which is precisely why Office Macro viruses were such a problem, because speadsheets could contain programs.)

No, pickling and unpickling files in your user's data-dir isn't a big deal, until it is because your users wanted to share their data online. They'll sync their data-folder with Dropbox, and then their account gets compromised, and the next time they launch your program they've got a virus. They'll download a 'completed savegame' from a sketchy site, and now they've got a virus. They'll get a phishing e-mail, but it's not one of those zips or exes or whatever, it's a file-format they know is your program, and surely that's safe, right?

Don't make your file formats insecure. Don't pickle.

Re:Exploiting Misuse of Python's “Pickle” by IanCal on Monday June 06, 2016 @04:42AM (#11845397)
My rather poorly made point is that whether it's a security problem or not depends on what you're using pickle for. My typical use case is simply as a local cache for some slow computation in ad-hoc scripts. Being able to simply dump objects and load them back again without needing to write serialisation code is a great timesaver, and the only ways I can see that causing a security problem rely on an attacker already having significantly more access to begin with.

I don't like people making such strong statements about what others should and should not do, based on issues in some situations.