Re:Liblfds, a portable, license-free, lock-free data structu...
by jotux on Tuesday May 31, 2016 @07:01PM
(#11810955)
I agree completely with what you're saying but this:
>This looks like it was written by a 16 year-old student who heard "lock free", and went "cool, I'll write a library!" And he missed the last 40 years of software best practices.
Is not constructive criticism, it's just being rude.
Re:Liblfds, a portable, license-free, lock-free data structu...
by adekok on Wednesday June 01, 2016 @10:03AM
(#11814398)
You're unwilling to give constructive criticism yourself. I suspect because you know that by your standards, any negative criticism can be labeled as "mean and rude".
You've been given multiple opportunities to give positive criticism yourself. And you've refused. Your position is entirely negative.
For something where you are more offended than the author of the library. He's an adult, and he can defend himself. You're infantilizing him by protecting him from things where he doesn't want protection.
The code of conduct you linked to would seem to prohibit your overly negative behavior.
i.e. your comments have come across (to use a common phrase here), as toxic.
> >Adults should be able to take criticism. If they can't, I have very little sympathy for them.
> Again, your outlook is toxic to newcomers. Yes people should be able to handle criticism but you should be capable of crafting that criticism in a way that isn't mean spirited and rude.
I don't think that's a fair statement. If someone has done something badly, they've done it badly and they should be told that. You're not doing anyone any benefit by sugar coating it by first saying "great job on trying". Personally, I prefer getting a frank and honest review of my work rather than having to tease out why someone doesn't like it but they won't state it plainly because they'll "hurt my feelings". We're discussing code, and if code is bad then we should make it clear that it's bad, say how to do it better, and move on.