News for hackers. Stuff that matters.
Re:Code reviews aren’t just for catching bugs by Cthulhu_ on Friday May 13, 2016 @09:54AM (#11690404)
Taking the time and effort to comment on grammar or code style preferences is anything but attempting to prove smartness; it's stupid work that shouldn't be necessary if the one submitting the code for review paid more attention to those basics.

If you can't write a coherent sentence or consider a style guide 'anal', you have no place developing for a project that is serious enough to warrant code reviews.

Another thing, if someone submits a PR with basic errors like that, they distract from the things that should be looked for in a code review - bugs, implementation details, etc.

There are no comments on this comment yet.