Re:Deprecating: java.util.Optional.get()?
by steveklabnik on Thursday April 28, 2016 @12:34PM
(#11590062)
It's a tagged union. Sometimes the tag can be elided, sometimes not. If you did a direct cast, you'd lose the tag. More specifically though, layout is undefined, so you don't know if the tag is first or last, strictly speaking.
Lints for unwrap already exist :)
> It's a tagged union. Sometimes the tag can be elided, sometimes not. If you did a direct cast, you'd lose the tag. More specifically though, layout is undefined, so you don't know if the tag is first or last, strictly speaking.
Do you not have a generic syntax for unwrapping a tagged union, forcibly assuming that it's one particular component? That seems like something users would want.
Re:Deprecating: java.util.Optional.get()?
by steveklabnik on Thursday April 28, 2016 @01:56PM
(#11590697)
That is exactly what unwrap() is...
(More specifically, it's a method which uses `match` internally to do this)
Ok, so I'm advocating forcing users to always use match directly if they want to do that. That helps ensure unsafe code looks unsafe.
Re:Deprecating: java.util.Optional.get()?
by tatterdemalion on Thursday April 28, 2016 @02:48PM
(#11591071)
Maybe your issue is that the `get` method in Java sounds pretty innocuous, but in Rust the `unwrap` method is notorious. Every Rust user knows that it can panic. Requiring a match would increase verbosity and decrease clarity.
What's the representation of an optional then? Doesn't make use of some generic concept like subclasses or unions? Surely you have a generic syntax for "assume this union is this particular member" or "assume this base class is this particular subclass" or the like?
> I'm not sure that it's any more verbose or scary looking, though.
I guess the point is that I want all cast-like operations to look alike (or at least to have a way to consistently distinguish them from ordinary methods) so that I can flag them all up consistently in code reviews, linters etc.