News for hackers. Stuff that matters.

A comment on We are ruthless on code reviews. Parent comment

Re:We are ruthless on code reviews by Niksko on Wednesday April 27, 2016 @11:36AM (#11581334)
Makes sense, but there are ways of being even petty and nitpicky without being condescending or rude. State facts, don't throw insults, don't demean or belittle.
[ Parent | on HN ]
Re:We are ruthless on code reviews by coredog64 on Wednesday April 27, 2016 @11:51AM (#11581525)
One good rule I was given by a tech lead is to not use the word "you" in the PR comments. PR comments are a discussion on the failure of the code, not of the individual. Avoiding "you" allows for some separation between the two.
[ Parent | on HN ]
Re:We are ruthless on code reviews by cachemiss on Wednesday April 27, 2016 @12:01PM (#11581631)
I always use "we", and I almost always phrase things as a question.

Example: "So we are doing X here, which I think will probably do Y, which could have adverse affects Z, are we sure we want to do this?"

[ Parent | on HN ]