Indefinite gag orders are definitely unconstitutional, and it has been proven before in Court. There should be an automatic limit as well for when the gag orders expire, like say 1-3 months, or whatever is considered "reasonable" for an investigation. After that, the government should have to get extensions every 3 months from a judge. After 2 or 3 years, the extension should be obtained only from a federal judge.

And it goes without saying that the gag orders should only be given in very specific scenarios, not for all data requests, or anytime the government wants to give one.