News for hackers. Stuff that matters.
Re:More code review tools by cdcarter on Tuesday March 15, 2016 @08:08PM (#11294039)
Seriously -- disappearing comments is very sad.
Re:More code review tools by scoot on Tuesday March 15, 2016 @09:41PM (#11294410)
Disappearing comments mean they've been adressed. And they don't actually disappear, they're just minimised.
Re:More code review tools by Elv13 on Wednesday March 16, 2016 @01:01AM (#11295141)
No, if you comment on the commits themselves rather than the PR 3rd tabs, they disappeared (at least before this change). The only place they were left is your emails, an hardcoded URL or your feed. This was (is?) bad...
Re:More code review tools by wanderr on Wednesday March 16, 2016 @02:33AM (#11295436)
they do disappear in one sense: the link to them sent out in the email telling me about them goes away. And if I have a bunch of collapsed comments, it's annoying as hell to find the right one. This is usually an issue when the developer says something like:

"ok, I fixed that, but what do you think about xyz?"

Now I have to go to the comments and expand 35 of them until I find the right one so I can respond to their question.

It's also sometimes the case that changing a line is not the same as addressing a comment, or maybe it only addresses part of a comment, or maybe they just changed whitespace because now all that code you commented on is inside an if...

Re:More code review tools by steveklabnik on Tuesday March 15, 2016 @11:05PM (#11294694)
Yes, this is my largest pain points with PRs: I'd like to be able to collapse comments that were resolved, but weren't made on a line that changed.