News for hackers. Stuff that matters.
Re:More code review tools by vikiomega9 on Tuesday March 15, 2016 @05:39PM (#11293222)
Are 200 line diff common? I feel like having focused patches are useful for everyone. Including git bisect and CI/CD.
Re:More code review tools by oinksoft on Wednesday March 16, 2016 @12:06PM (#11298360)
The line count of a diff has nothing to do with how focused the patch is. Some PRs are simply larger than others due to the language in use or the nature of the code being changed.

Presumably a codebase in an array-oriented language would have miniscule PRs, which is irrelevant (discussion of PL merits aside).

Re:More code review tools by majewsky on Wednesday March 16, 2016 @08:47AM (#11296822)
Totally. Just click "rails generate" twice. ;)
Re:More code review tools by dromtrund on Tuesday March 15, 2016 @05:44PM (#11293248)
I read it as a separate diff 200 lines later. But I guess pull requests could easily have that big diffs in a public repo