News for hackers. Stuff that matters.
Re:More code review tools by erichurkman on Tuesday March 15, 2016 @02:35PM (#11291930)
I'd love a UI way to enable `?w=1` whitespace mode, especially for html/json/yaml files. I have a feeling a lot of reviewers don't know about it and spend an inordinate amount of time squinting to see what changes when it was a whitespace-only change.
Re:More code review tools by tyingq on Tuesday March 15, 2016 @02:53PM (#11292081)
This! ?w=1 has existed for years, with no UI way to access it.

Compare two views of the same commit (found this by searching for any commit on github with the word "indent" in it)

https://github.com/douglascrockford/JSON-js/commit/1e3869cb3... (133 additions and 127 deletions)

https://github.com/douglascrockford/JSON-js/commit/1e3869cb3... (30 additions and 24 deletions)

Re:More code review tools by mwarkentin on Tuesday March 15, 2016 @04:07PM (#11292576)
On top of that.. when you're in `?w=1` view you can't leave line-by-line comments. :facepalm:
Re:More code review tools by xPaw on Tuesday March 15, 2016 @03:05PM (#11292169)
I have a userscript that does just that, however it needs to be updated to account for these new review tools.

https://gist.github.com/xPaw/de6ee132a2e267ef6960

Re:More code review tools by nathankleyn on Tuesday March 15, 2016 @02:42PM (#11291979)
Some similar option for enabling patience diffing as well would be amazing. Those two options in combination would certainly make a not insignificant amount of PRs much more readable.
Re:More code review tools by alxndr on Tuesday March 15, 2016 @07:57PM (#11293984)
I created a reminder for myself so that every six months I write an email to GitHub asking for someone to create a user option for this whitespace setting.
Re:More code review tools by wclax04 on Tuesday March 15, 2016 @02:47PM (#11292025)
I REALLY wish I could exclude certain file types from the view.