Re:Add Reactions to Pull Requests, Issues, and Comments
by scatters on Friday March 11, 2016 @06:47AM
(#11266020)
C++ standardization votes on a 5-point scale: Strong For, For, Neutral, Against, Strong Against. I think it's important to be able to express the lack of an opinion, although I guess you could do that on a 4-point scale by abstaining.
Re:Add Reactions to Pull Requests, Issues, and Comments
by new_hackers on Friday March 11, 2016 @10:48PM
(#11271313)
I've often wondered why the "two thumbs up" isn't really used anywhere that I've seen. It is a logical progression that gives more precision to the reaction.
Re:Add Reactions to Pull Requests, Issues, and Comments
by gkoberger on Thursday March 10, 2016 @06:56PM
(#11263547)
For what it's worth, the "thumbs down" emoji is named ":-1:".
Re:Add Reactions to Pull Requests, Issues, and Comments
by goldenkey on Thursday March 10, 2016 @09:37PM
(#11264275)
+0 and -0 are equal..
Re:Add Reactions to Pull Requests, Issues, and Comments
by lccarrasco on Thursday March 10, 2016 @09:48PM
(#11264321)
I believe the implied meaning is:
+0 -> support from the sidelines (like for a change that doesn't directly affect you)/something that's not urgent but would be nice
-0 -> disagree from the sidelines/disagree with the solution but can't think of a better one
Re:Add Reactions to Pull Requests, Issues, and Comments
by alecdbrooks on Thursday March 10, 2016 @11:29PM
(#11264651)
I would enjoy it if they used +ε and -ε for that, although +0 and -0 is probably clearer.
Re:Add Reactions to Pull Requests, Issues, and Comments
by rtpg on Friday March 11, 2016 @12:48AM
(#11264873)
like that idea! Dunno how many people have epsilon easily accessible on their keyboards though.
Re:Add Reactions to Pull Requests, Issues, and Comments
by geofft on Thursday March 10, 2016 @11:54PM
(#11264718)
Those terms for code-review voting are (almost certainly) from Apache, which treats them differently. From http://www.apache.org/foundation/voting.html :
+0: 'I don't feel strongly about it, but I'm okay with this.'
-0: 'I won't get in the way, but I'd rather we didn't do this.'
(These votes are strings, not numbers, though they closely resemble numbers. See also the existence of a "++1" vote.)
Re:Add Reactions to Pull Requests, Issues, and Comments
by inopinatus on Thursday March 10, 2016 @10:26PM
(#11264467)
Arithmetically true, but they have different IEEE 754 floating point representations.
Also, my inner mathematician understands that function limits can tend towards zero from above, or from below.
Zero ain't always just a big fat zero.
Feel like that would be very useful