Re:Add Reactions to Pull Requests, Issues, and Comments
by mrharrison on Thursday March 10, 2016 @06:46PM
(#11263506)
This comment is basically a down vote of github's down vote. Comments should be the down vote, because someone needs to explain why a suggestion, answer, code change, submission, etc... is not a good option. If that comment (down vote) is a good idea, it will then be up voted.
[ Parent
| on HN ]
Re:Add Reactions to Pull Requests, Issues, and Comments
by jbrooksuk on Friday March 11, 2016 @04:09AM
(#11265554)
Why should you never have to explain why you're in agreement with something? What kind of culture do we have if you only have to explain why you disagree with something?
Re:Add Reactions to Pull Requests, Issues, and Comments
by frigo_1337 on Friday March 11, 2016 @05:16AM
(#11265737)
The "positive" things about the issue/pull request etc. is presumably already explained by the author.
"Issue 1234: We need this feature because reasons A, B and C."
If you don't think that A, B and C justifies the change, send a downvote and/or explain why A, B and C aren't good enough reasons.
An upvote is sufficient to say that "Yes, I agree with A, B and C. Do it."
Of course, if you agree with the change but for reasons other than A, B or C, you can leave a comment to start a discussion. It has nothing to do with culture. It's just a way to minimize the redundant "Yes, I agree with what you just said".
Re:Add Reactions to Pull Requests, Issues, and Comments
by xentronium on Friday March 11, 2016 @06:14AM
(#11265925)
But there could already be a reasonable explanation for -1 vote in the thread. Are you suggesting to repeat it or write "agree with @foobar on his comment"? That's more noise.
Re:Add Reactions to Pull Requests, Issues, and Comments
by bryanlarsen on Friday March 11, 2016 @09:58AM
(#11266928)
You upvote the negative comment.