News for hackers. Stuff that matters.
Re:GitHub responds to Dear GitHub letter by greggman on Friday February 12, 2016 @09:51AM (#11087533)
I don't have any giant opens source projects so I guess I don't get bothered by the +1s and cries for help. Chromium gets those on their non-github issues. So does Firefox. I'm guessing WebKit does too.

My biggest issue, which I guess is a non-issue for most others?, is I hate when reviewing a PR that every single line comment generates a message/email.

Maybe it's because I'm used to Rietveld but my normal workflow is to start reading the patch and adding comments. I might have made 10 separate line comments before I get to a part of the patch that invalidates all those comments. Therefore I don't want them sent until I'm ready. I want to be able to make line comments across all files in the PR and only when I'm ready, send them as one coherent message.

As it is now, AFAICT, the only way to do this is to write line comments in some other file on my computer and then later manually find the lines again in github and add them one at a time. Rietveld also lets you respond to line comments inline and mark them as "done".

is there anything for github that does the same? Maybe one of their offline tools?

Re:GitHub responds to Dear GitHub letter by bradfitz on Friday February 12, 2016 @11:43AM (#11088458)
I've been working on a bot to copy Github Pull Requests into Gerrit reviews, using the Google-hosted Gerrit servers.

My bot isn't running publicly yet, but you can see the start of it working at:

https://github.com/grpc/grpc-go/pull/546 or https://github.com/grpc/grpc-go/pull/545

(Code is at https://github.com/LetsUseGerrit/gerritbot for now, but I don't imagine anybody would use the code themselves... they'd only interact with it via the Github bot)

Re:GitHub responds to Dear GitHub letter by jeblair on Friday February 12, 2016 @01:22PM (#11089224)
Gerrit has an excellent REST API, and because I like working with code in a terminal, I wrote Gertty -- a terminal based interface to Gerrit. It should work with the Google hosted servers.

https://pypi.python.org/pypi/gertty

Re:GitHub responds to Dear GitHub letter by hueving on Friday February 12, 2016 @06:49PM (#11091538)
Gertty is the greatest greatness ever. Doing code reviews on a plane and syncing up when back online is so cool. Thank you for your work on this.
Re:GitHub responds to Dear GitHub letter by howeman on Friday February 12, 2016 @01:00PM (#11089044)
Is there any public "how to" about Gerrit? I've interacted with it a few times for Go codereviews, but not frequently enough to get comfortable. Really simple things like finding the "submit comments" button I have to spend five minutes finding every time.
Re:GitHub responds to Dear GitHub letter by endtime on Friday February 12, 2016 @01:18PM (#11089188)
I don't know of a general "how to" but 'a' is a keyboard shortcut to send a reply (with comments).
Re:GitHub responds to Dear GitHub letter by pbh101 on Friday February 12, 2016 @01:31PM (#11089308)
Expanding on this, typing '?' will bring up the help, like gmail.
Re:GitHub responds to Dear GitHub letter by masklinn on Friday February 12, 2016 @10:45AM (#11087976)
> My biggest issue, which I guess is a non-issue for most others?, is I hate when reviewing a PR that every single line comment generates a message/email.

> is there anything for github that does the same? Maybe one of their offline tools?

Nope. Even the API doesn't allow this, you can only create one "review comment" at a time and no matter how fast you create them (or if you carefully create all of them over a persistent connection) each and every one of them will generate one notification and one outbound mail.

That went pretty well the first time I tried to get a linter to annotate a PR. The annotation worked, but I discovered some people's mailboxes can not handle getting 50 mails from the same source in a fraction of a second (and oddly enough people are not fond of getting 50 one-line emails from the same place).

(I asked github support about it, they confirmed the only workaround is to not use inline comments)

Re:GitHub responds to Dear GitHub letter by nitrogen on Friday February 12, 2016 @11:16AM (#11088255)
You should also be able to switch to digest emails from GitHub. Do they support that?
Re:GitHub responds to Dear GitHub letter by striking on Friday February 12, 2016 @12:07PM (#11088637)
Users might not, even if GitHub does. I would hate to get 50 emails because I don't want digests and I watch a certain project.
Re:GitHub responds to Dear GitHub letter by phasmantistes on Friday February 12, 2016 @12:15PM (#11088696)
I was actually shocked two weeks ago when I was talking to someone about Gerrit and they complained that their comments were never addressed. Turns out they hadn't been hitting the "Publish Comments" button, and had been assuming that every draft comment they left was being sent as an individual email.

This taught me (or reminded me of) two things:

* GitHub is so dominant that even its poor decisions are being enshrined as "the way things work"

* Gerrit really needs some UI love as well.

Re:GitHub responds to Dear GitHub letter by jeblair on Friday February 12, 2016 @01:20PM (#11089209)
Hopefully the recently begun work on a Polymer based interface (PolyGerrit) will help in that department.
Re:GitHub responds to Dear GitHub letter by sethammons on Friday February 12, 2016 @12:55PM (#11089008)
Not github, but you may be interested in http://phabricator.org/. We hired a guy a while back who swore by it. We had too much momentum in github, so it did not catch on at our org. One of his favorite features, if I recall as it was a few years ago, is what you are talking about.
Re:GitHub responds to Dear GitHub letter by mconley on Friday February 12, 2016 @10:11AM (#11087680)
Review Board works with GitHub and allows you to publish your review when you're ready.
Re:GitHub responds to Dear GitHub letter by delroth on Friday February 12, 2016 @10:57AM (#11088085)
I recently switched our large-ish GitHub project to use reviewable.io for code reviews. The UI can be hard to understand sometimes, but so far everyone agrees it's a tremendous improvement over GitHub's joke of a code review UI.
Re:GitHub responds to Dear GitHub letter by piotrkaminski on Friday February 12, 2016 @08:40PM (#11091988)
Reviewable founder here. I'd love to get somebody to sit down with me and rant about the UI so I can figure out how to improve it. Let me know if you're game. :)
Re:GitHub responds to Dear GitHub letter by MoSal on Friday February 12, 2016 @12:12PM (#11088677)
Besides the UI, "reviewable.io" is a memory hog. It's simply unusable if you try to browse the site from a device without a lot of free memory (e.g. older tablets, ARM SoCs, etc).
Re:GitHub responds to Dear GitHub letter by piotrkaminski on Friday February 12, 2016 @08:35PM (#11091972)
Reviewable founder here. Yep, Reviewable is a heavy client-side app, and I make no apologies for it. Mobile devices are getting powerful very quickly (you can already use Reviewable pretty much fine on modern phones/tablets) and the target audience of developers generally needs reasonably powerful devices anyway. I'd rather miss out on some users in the short term than lock myself into an obsolete server-centric architecture in the long term...

That said, performance is always an issue, it's just a question of where to set the target.

Re:GitHub responds to Dear GitHub letter by jsight on Friday February 12, 2016 @10:00AM (#11087596)
Excellent idea... some notion of a review session would be nice.
Re:GitHub responds to Dear GitHub letter by chris_wot on Friday February 12, 2016 @10:03AM (#11087619)
Gerrit does this as well.
Re:GitHub responds to Dear GitHub letter by spankalee on Friday February 12, 2016 @10:33AM (#11087861)
Just continue to use Reitveld :)