News for hackers. Stuff that matters.
Re:Check-in before code review is an antipattern by nradov on Saturday January 23, 2016 @08:43PM (#10961082)
There's no reason you can't do code reviews on SVN branches prior to merging to the trunk. My teams do this every day. It helps to have a dedicated code review tool such as Atlassian Crucible.

And I wouldn't necessarily characterize SVN branching as "clunky, user-unfriendly and error-prone". It might be slightly worse than Git, but with modern tools like Eclipse there's hardly a difference. I've never found SVN branching difficult at all.

Re:Check-in before code review is an antipattern by nova22033 on Saturday January 23, 2016 @08:45PM (#10961088)
What's your workflow? Do developers check in bug fixes in trunk? TIA.
Re:Check-in before code review is an antipattern by abstractbeliefs on Saturday January 23, 2016 @08:57PM (#10961116)
Not him, but where I last worked once you had your dirty working directory, you'd run rbtool to upload the changes to reviewboard, where they could get looked at.

Once it was approved, you committed. A hook in the svn server would check that you had a link to the reviewboard entry, the entry was approved, and that your changes matched the diff that was approved.

Re:Check-in before code review is an antipattern by nradov on Saturday January 23, 2016 @09:00PM (#10961120)
Developers check in all changes (whether bug fixes or new features) on task branches first, and use those branches to run tests and conduct code reviews prior to merging to the trunk. That way the trunk build almost always works, and at any point in time we can deliver the trunk code to customers.