News for hackers. Stuff that matters.
Re:Check-in before code review is an antipattern by greglindahl on Saturday January 23, 2016 @08:26PM (#10961034)
Don't push directly to master isn't what anyone is going to think the title of the article means, either.
Re:Check-in before code review is an antipattern by ghusbands on Saturday January 23, 2016 @08:35PM (#10961063)
You're saying that in reply to someone who clearly did, which seems disingenuous. I also read it the way the author intended.
Re:Check-in before code review is an antipattern by klodolph on Saturday January 23, 2016 @10:31PM (#10961343)
I don't think "disingenuous" is necessarily appropriate here. When people say "anyone" they don't generally mean "anyone, without exception".
Re:Check-in before code review is an antipattern by AznHisoka on Saturday January 23, 2016 @08:47PM (#10961093)
Never assume or generalize.

I thought that's what the title meant as well.

Re:Check-in before code review is an antipattern by mikeash on Saturday January 23, 2016 @09:22PM (#10961176)
I assumed the title couldn't possibly mean that, but I also had no idea what else it could mean.
Re:Check-in before code review is an antipattern by zeckalpha on Saturday January 23, 2016 @09:52PM (#10961243)
Why couldn't the title mean that? It's not an unreasonable restriction.
Re:Check-in before code review is an antipattern by mikeash on Saturday January 23, 2016 @10:06PM (#10961284)
Sorry, I'm referring a bit too far up the chain with "that." The only meaning I could imagine for the title was that one shouldn't place code into source control at all before code review, which is too absurd to possibly be what was meant.
Re:Check-in before code review is an antipattern by koko775 on Saturday January 23, 2016 @10:37PM (#10961356)
(oops! sorry for the accidental flag. I was trying to reply and misclicked)

That's the very first thing that occurred to me, actually.