Re:Show HN: Static Analysis Tool for Dockerfiles in Haskell
by boothead on Tuesday January 12, 2016 @04:15PM
(#10890459)
The code looks good. One thing you might want to consider is using applicative style for parsing. So
taggedImage :: Parser BaseImage
taggedImage = do
name <- many (noneOf ":")
reservedOp ":"
tag <- many (noneOf "\n")
return $ TaggedImage name tag
Would end up something like: taggedImage :: Parser BaseImage
taggedImage = TaggedImage <$> (many (noneOf "\n") <* reservedOp ":")
<*> (many (noneOf "\n")
If you are an experienced Haskeller I would be very glad if you look over the project and problems in an issue. Because mostly I have no idea whether what I am doing is idiomatic or not.