News for hackers. Stuff that matters.
Re:New string formatting in Python by mixmastamyk on Sunday January 03, 2016 @11:16PM (#10833962)
FUD: applies to literals only. There is nothing that could happen in the string that couldn't happen in your code already. No new security concerns.
Re:New string formatting in Python by Animats on Sunday January 03, 2016 @11:23PM (#10833974)
Example given:

    myquery = sql(i"SELECT {column} FROM {table};")
What could possibly go wrong?
Re:New string formatting in Python by icebraining on Monday January 04, 2016 @06:15AM (#10834910)
How is that any different from any other string formatting mechanism?

  myquery = sql("SELECT %s FROM %s" % (column, table))
Re:New string formatting in Python by berdario on Monday January 04, 2016 @06:43AM (#10834998)
plenty of things can go wrong, since you have control of how many and which variables to interpolate, e.g:

    i"SELECT {settings.SECRET_KEY};"
PS: (I don't know why but HN is not updating the page with the reply links needed, so I'll just edit this)

Yes, I agree. I think that the misunderstanding happened when mixmastamyk wrote

> That's a good thing due to security reasons as arbitrary expressions are allowed. There are plenty of templating solutions available

The point is that even if you don't allow arbitrary expressions (which imho are a mistake, and of which I haven't seen a single use case yet), having this kind of interpolation from strings that are not literals (i.e. are not in the trusted source code) would still be a security issue

Since the PEPs apparently don't propose to extend this to non-literals, we're safe. But it's better to be wary and attentively review such proposals...

In fact, I just realized right now that Animats might have misunderstood PEP 501, since

    sql(i"SELECT {column} FROM {table};")
should be perfectly safe from sqli vulns

PPS: Unless Animats is pointing out how switching i'' for f'' is a terribly simple mistake to do and hard to spot during a code review... I agree with that

Re:New string formatting in Python by icebraining on Monday January 04, 2016 @06:49AM (#10835024)
But again, if you can inject that into the source code, why can't you just do

  "SELECT {};".format(settings.SECRET_KEY)
Remember that the interpolation only works for string literals, you can't inject that from external input.