PHP Bug: #50696: number_format when passed a 0, returns null

Re:PHP Bug: #50696: number_format when passed a 0, returns null by rbanffy on Sunday January 10, 2010 @06:05PM (#1043862)

+1.

It should thrown an exception and abort the script with an ugly error traceback.

If the documentation says "float" and you can hand it a numerical string, then either the function or its documentation have a bug that needs correcting.

[ Parent | on HN ]

Re:PHP Bug: #50696: number_format when passed a 0, returns null by bozmac on Sunday January 10, 2010 @10:38PM (#1044253)

I wouldn't go as far as throwing an exception. A notice maybe.

[ Parent | on HN ]

Re:PHP Bug: #50696: number_format when passed a 0, returns null by rbanffy on Monday January 11, 2010 @07:06AM (#1044913)

Asking a function that formats a number and that is defined that way in the documentation to format a string is a programming mistake. As the discussion clearly states, it's a minor change in application code that would make it both clearer and more robust.

I would go as far as recommend using a USB shock device to issue a warning to the programmer every times a mistake like this is made. ;-)

[ Parent | on HN ]