Re:Mimic – abusing Unicode to create tragedy
by ygra on Friday October 23, 2015 @10:07AM
(#10438601)
> blacklist pull requests from anyone who forks it
Why, if I may ask? If they introduce compile errors in your project, those should be caught by the CI build and test run, shouldn't they? In any case, accepting a code change just by looking at the diff and without even trying it out sounds like not the best course of action to me anyway.
Re:Mimic – abusing Unicode to create tragedy
by sheraz on Friday October 23, 2015 @11:33AM
(#10439237)
Yes. A good CI will blow up any malicious pull requests provided you are using a compiled language. Or if interpreted, you need sufficient code coverage that your tests will blow up
Why, if I may ask? If they introduce compile errors in your project, those should be caught by the CI build and test run, shouldn't they? In any case, accepting a code change just by looking at the diff and without even trying it out sounds like not the best course of action to me anyway.