I only did upgrades on my old MBP too, and always found it fine. I went from Leopard to Snow Leopard to Lion to Mountain Lion to Mavericks. Nothing serious went wrong at any point (though I did have to reinstall or update the odd program), and there was no noticeable deterioration in performance over time.
There was the odd infuriating bug (I'm not convinced it's tested as thoroughly as Windows is...), but overall it was fairly trouble free and the smooth upgrade process played a part in my decision to buy another. It certainly wasn't the price, at any rate.
> The one annoyance I've encountered is that the installer will move everything in /usr/local out of the way before doing the upgrade and moving it back.
This can be a significant point. I thought my computer was bricked when I did one of the previous upgrades (maybe Mavericks?) and the upgrade took something like 14 hours (with no change in the progress bar).
It's definitely mind-boggling just how inefficient it is – feels like 1-byte writes followed by a full fsync based on how it can keep an SSD capable of 10K ios busy for a period measured in hours.
The one annoyance I've encountered is that the installer will move everything in /usr/local out of the way before doing the upgrade and moving it back. If you have a large Homebrew install, it will be much faster to move the directory first and restore it later rather than waiting for the file-by-file copy to complete, even on when using SSDs.