Re:How to Write Unmaintainable Code (1999)
by littletinman on Friday September 18, 2015 @11:37AM
(#10239792)
This should be renamed to: "Common red flags to look for in merge requests and code reviews" and handed to every rookie, mid-level, and senior developer on your project!
[ Parent
| on HN ]
Re:How to Write Unmaintainable Code (1999)
by omouse on Friday September 18, 2015 @11:42AM
(#10239828)
Depending on the team you can get away with some of these. Have a manager/PHB that actively discourages unit testing? You don't need to commit your unit tests or write them at all! No one fixes an instance of copy/paste coding? Great, now you too can be efficient by copying and pasting everywhere. No one uses a code formatter or uses different formatting styles? Good! Now your style can shine!
These are all good red flags to check for in existing code bases before you join a team. If you see them, chances are their code review process is poor or non-existent and you'll be fighting a battle against crap code every single day.
Re:How to Write Unmaintainable Code (1999)
by littletinman on Friday September 18, 2015 @11:47AM
(#10239864)
Looking through the codebase for these to assess the teams review health is a fantastic idea!