News for hackers. Stuff that matters.
Re:How to Write a Git Commit Message by webo on Sunday September 13, 2015 @05:14PM (#10212805)
When you work on a team that requires code reviews (pull requests) before every check-in, the "body" portion of the commit does not really make sense as the developer pretty much has to include that information in the code review description either way.

Most teams automatically put a link to the corresponding code review in the commit message/body.

Re:How to Write a Git Commit Message by unfunco on Sunday September 13, 2015 @05:22PM (#10212832)
I'd still prefer a body with a good commit description, since review descriptions are not attached to the history.

I've been thinking about this a little recently, the conversations that determine the direction of a product are not part of the history, if a repository is shared there's no way to see that information without going through emails, or going through issues on GitHub or Bitbucket or whatever else.

Re:How to Write a Git Commit Message by webo on Sunday September 13, 2015 @05:32PM (#10212858)
Is this something we can change though?

As you mentioned, these conversations happen everywhere including offline meetings and hallway chats.

Re:How to Write a Git Commit Message by ReidZB on Sunday September 13, 2015 @05:21PM (#10212824)
On GitHub, single-commit PRs automatically have their body text set to the body text of the commit. (Annoyingly, GitHub doesn't reflow the body text, so it looks "jagged"...)

For multiple-commit PRs, I usually just give some surrounding context and let the reviewers read each commit message separately (with the three dot button).

Re:How to Write a Git Commit Message by e28eta on Sunday September 13, 2015 @07:32PM (#10213121)
At work they're consolidating systems, and we might lose our entire code review history. Having some redundancy isn't necessarily a bad thing.