News for hackers. Stuff that matters.

tawat987

Re:Why Working on Monoliths Is Bad for Your Career on Wednesday August 07, 2019 @10:05PM (#20641169)
They're just describing the difference between good development practices and bad ones.
Re:Tips for reviewing code you don’t like on Monday July 08, 2019 @06:37PM (#20387407)
I disagree with the basic premise of the article that maintainers are obliged to merge code changes by default.

One reason is that the maintenance burden falls on more than just the author, so there needs to be some consideration on whether it is maintainable and whether the people involved are willing and able to maintain it.

Particularly if the change adds a public API or behavior, it may have to be maintained for the life of the codebase.

Also, some projects have very high reliability expectations and you have to assume that code is broken until proven otherwise. I won't merge code until the author has demonstrated via tests, comments and clearly-written code that the change does as expected and doesn't introduce potential issues.

The attitude in the article isn't particularly conducive to the long-term health and quality of a project, since you get a bunch of authors ramming through their changes based on their agenda and end up with an inconsistent mess that nobody wants to maintain.

Re:OPP: Other People's Problems on Saturday May 18, 2019 @02:01PM (#19948772)
I think it's also important to approach it with some humility about whether you fully understand the contours of the problem. Also I think you need to prove that you can and will do something about one problem before you start talking about all the other things you want to fix. Otherwise you have no credibility and others could reasonably think you're just complaining.