reviewmoreprs

I think the entire map was red on Tuesday in large part because of incredibly racists thoughts and posts like these becoming more and more prevalent. The idea that white people should not be a majority and if they are it's due to racism is an extremely disgusting and racist statement.

If your take is that blindly approving merges with 0 care is actually a good thing and that I "lack understanding" then I simply have to disagree lol. Good luck with that.

Well then why does the PR template used at the company require manual validation steps on every PR if it's not expected that reviewers do them? Do you really think 5 seconds was enough time to "sanity check" the PR? Do you think 5 seconds was enough time to even click the code tab? Why are two "reviews" even required if the reviewers are actually expected to simply rubber stamp every single PR that comes through?

Edit: "the fix for a bad PR is more PRs" has got the be the worst take I've seen in years.

I recently quit a job, for a large number of reasons, but the one most relevant to this post was the topic of my github numbers. My manager gave me a "needs improvement" review, citing my "bad numbers" and comparing them to several of my teammates. Their numbers, to me, were laughably high.

I thought I was doing pretty good on PR reviews. I do one or two a day. I read the description, sometimes more than once. I read through the practical testing steps. I follow them, sometimes with a lot of setup required. I really make sure it does what it's supposed to do. I read the code, line by line. Sometimes before I do the practical testing, sometimes after. But I read through the code, several times. I don't know how you wouldn't. Functions are calling other functions I haven't gotten to yet. So I read through the code multiple times. I don't just try to understand what it does, but why it does what it does. Is there a better way? Is this going to change or impact something else it should or shouldn't? A good code review can easily take an hour or more, in my humble opinion. Two reviews a day on top of all my bs meetings and I still have my own shit to do. How does my teammate have triple my PR reviews for the quarter? Seems crazy.

One day I'm pair programming with one such teammate. We finish the task, I create a PR, write a description etc. I press the ready for review button and start to say, "see you later bla bla" and suddenly there's an approval on the PR. It's been 5 seconds, tops. It's the other teammate with 10x code ninja numbers on the team. I remark that approval was pretty quick. My teammate forces a nervous sounding laugh. They work together ever day and seem pretty close, huh.

Anyway, after that, every morning after I made coffee and opened my laptop I'd spend 10-15 minutes just going down the list of open PRs on the project and approving them. I didn't look at the code or even bother reading the description. I just approved them all. I also started opening PRs for stupid shit like minor typos in comments that I'm quite sure no one even reads.

My next review my manager said I had made some impressive improvements and gave me a "meets expectations".

I'm looking for a job in a different industry now. I'm not out of software development, I just don't think I can work on another e-commerce webapp company run by MBAs again. I think I'd rather be broke.