News for hackers. Stuff that matters.

barret7sc

Re:Maturity on Tuesday September 10, 2019 @11:26AM (#20929232)
My biggest issue with gitlab code review is that it's unusable for large changes and large files. On large changes it sometimes won't even show all the changes.

Also the auto-collapse size is far too small, and the fact you can't even see the diff for some large changes in infuriating. It makes using it for code review a struggle. My company is trying to move us all to gitlab-ee, but the lack of features and polish to the code review tool is preventing some teams from making the jump.

I feel like the code review portions are more like a half-circle, and not a heart. There are so many deficiencies that make it unusable for large projects.

If I were gitlab I would look at gerrit for inspiration on what you should use for code review. It's ugly, but it's very functional and performs quite well on meager hardware.

I know there are feature requests to make code review more usable but I can't understand how you could dogfood that code review tool and not go insane.

Also, merge trains for FF-only repos, please!