WaltSellers
The state of the operation is "success" (err==zero) until some step changes the state to "failure" (non-zero).
The state should be assumed to be "failure" until the last step changes it to "success".
Execution will arrive there somehow, but the 'how' is unclear. The word "fail" implies you should reach that point only if there was an error, but that is a bad assumption in this case.
If the real answer to 'how did we get here?' was checked, then the bug could not hide in the undefined behavior. This would not allow a dangling goto to result in a false positive. A false negative will get someone's attention when their web page doesn't load.
Something like this could remove the undefined state:
goto pass;
fail:
if ( err == 0 ) {
assert( err != 0 ); // BUG! variable must contain an error number
err = kSomeAppropriateErrorNumber;
}
pass:
SSLFreeBuffer(&signedHashes);
SSLFreeBuffer(&hashCtx);
return err; - don't leave local variables uninitialized.
- don't try to hand-optimize lines unnecessarily.
- don't mix assignments into boolean expressions. (Which is really an unneeded optimization.)It might be more noticeable, but then, the original bug existed because no one noticed.