GraphEnthusiast

Implementing an Elliptic curve correctly is tricky, and in your post a quick CTRL-F didn't turn up the phrases "constant time" or "side channel". A good next step would be to look up various side channel attacks on elliptic curve implementations and work through mitigating them.

Also, your README needs a disclaimer, like others have said.

The rational numbers make up "zero percent" of the real numbers. It's a little hard to properly explain without assuming a degree in math, since the proper way to treat this requires measure theoretic probability (formally, the rationals have measure zero in the reals for the "standard" measure).

The short version is that the size of the reals is a "bigger infinity" than the size of the rationals, so they effectively have 'zero weight'.

Reference (very technical): https://math.stackexchange.com/questions/508217/showing-that...